Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Add full support for PiP option on iPad #336

Closed
sergeymomot opened this issue Mar 13, 2024 · 0 comments · Fixed by #384
Closed

[iOS] Add full support for PiP option on iPad #336

sergeymomot opened this issue Mar 13, 2024 · 0 comments · Fixed by #384
Assignees
@forgotvas
Labels
enhancement Relates to new features or improvements to existing features

Comments

@sergeymomot
Copy link

Right now picture-in-picture function on iPad doesn't work quite correctly:

  • PiP video closes when going to content list
  • when you go to another card and then back in the video, two videos start playing
  • (will be added later)

PiP option should work correctly

Exported.MPEG-4.movie.mp4
@sergeymomot sergeymomot added the enhancement Relates to new features or improvements to existing features label Mar 13, 2024
@forgotvas forgotvas self-assigned this Mar 18, 2024
@forgotvas forgotvas moved this to In Development in Open edX Mobile Roadmap Mar 20, 2024
@forgotvas forgotvas mentioned this issue Apr 1, 2024
Merged
@forgotvas forgotvas linked a pull request Apr 1, 2024 that will close this issue
Feat/pip mode #384
Merged
@forgotvas forgotvas moved this from In Development to In Code Review / Final Acceptance in Open edX Mobile Roadmap Apr 1, 2024
@rnr rnr closed this as completed Apr 9, 2024
@github-project-automation github-project-automation bot moved this from In Code Review / Final Acceptance to Done in Open edX Mobile Roadmap Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forgotvas forgotvas

Labels
enhancement Relates to new features or improvements to existing features
Projects
Open edX Mobile Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/pip mode edx/edx-mobile-marketplace-ios
3 participants
@rnr @forgotvas @sergeymomot