Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Improvements for Download videos functionality #251

Closed
Tracked by #242
sergeymomot opened this issue Jan 22, 2024 · 0 comments · Fixed by #279
Closed
Tracked by #242

[iOS] Improvements for Download videos functionality #251

sergeymomot opened this issue Jan 22, 2024 · 0 comments · Fixed by #279
Assignees
@eyatsenkoperpetio

Comments

@sergeymomot
Copy link

Based on comment #239 (review)

Need to improve/fix these moments:

  • If the internet isn’t available the download to device view replaced with noWifiMessage message. The noWifiMessage should be displaced on toggling on the download switch as an error

  • when downloading videos for a sub section, the circular progress appears with cross. It would be nice if we follow the prod app behavior and show loader without cross and on clicking the loader the download detail screen appears

  • the download progress bar flickers both on download to device view and download progress detail view
    https://github.com/openedx/openedx-app-ios/assets/2964930/71e07e8e-2ee3-4b9f-a4b7-35ba33c08f54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyatsenkoperpetio eyatsenkoperpetio

Labels
None yet
Projects
Open edX Mobile Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements for Download videos edx/edx-mobile-marketplace-ios
2 participants
@sergeymomot @eyatsenkoperpetio