fix: address feedback

OpenEdX/DI/AppAssembly.swift

@@ -175,6 +175,8 @@ class AppAssembly: Assembly {
         container.register(PushNotificationsManager.self) { r in
             PushNotificationsManager(
                 deepLinkManager: r.resolve(DeepLinkManager.self)!,
+                storage: r.resolve(CoreStorage.self)!,
+                api: r.resolve(API.self)!,
                 config: r.resolve(ConfigProtocol.self)!
             )
         }.inObjectScope(.container)

OpenEdX/Managers/PushNotificationsManager/Listeners/BrazeListener.swift

@@ -6,7 +6,6 @@
 //
 
 import Foundation
-import Swinject
 
 class BrazeListener: PushNotificationsListener {
 

OpenEdX/Managers/PushNotificationsManager/Listeners/FCMListener.swift

@@ -6,7 +6,6 @@
 //
 
 import Foundation
-import Swinject
 import FirebaseMessaging
 
 class FCMListener: PushNotificationsListener {

OpenEdX/Managers/PushNotificationsManager/Providers/FCMProvider.swift

@@ -13,8 +13,13 @@ import Swinject
 
 class FCMProvider: NSObject, PushNotificationsProvider, MessagingDelegate {
 
-    private var storage = Container.shared.resolve(CoreStorage.self)!
-    private let api = Container.shared.resolve(API.self)!
+    private var storage: CoreStorage
+    private let api: API
+
+    init(storage: CoreStorage, api: API) {
+        self.storage = storage
+        self.api = api
+    }
 
     func didRegisterWithDeviceToken(deviceToken: Data) {
         Messaging.messaging().apnsToken = deviceToken

OpenEdX/Managers/PushNotificationsManager/PushNotificationsManager.swift

@@ -8,7 +8,6 @@
 import Foundation
 import Core
 import UIKit
-import Swinject
 import UserNotifications
 import FirebaseCore
 import FirebaseMessaging
@@ -28,6 +27,8 @@ protocol PushNotificationsListener {
 class PushNotificationsManager: NSObject {
 
     private let deepLinkManager: DeepLinkManager
+    private let storage: CoreStorage
+    private let api: API
     private var providers: [PushNotificationsProvider] = []
     private var listeners: [PushNotificationsListener] = []
 
@@ -36,8 +37,10 @@ class PushNotificationsManager: NSObject {
     }
 
     // Init manager
-    public init(deepLinkManager: DeepLinkManager, config: ConfigProtocol) {
+    public init(deepLinkManager: DeepLinkManager, storage: CoreStorage, api: API, config: ConfigProtocol) {
         self.deepLinkManager = deepLinkManager
+        self.storage = storage
+        self.api = api
         super.init()
         providers = providersFor(config: config)
         listeners = listenersFor(config: config)
@@ -49,7 +52,7 @@ class PushNotificationsManager: NSObject {
             pushProviders.append(BrazeProvider())
         }
         if config.firebase.cloudMessagingEnabled {
-            pushProviders.append(FCMProvider())
+            pushProviders.append(FCMProvider(storage: storage, api: api))
         }
         return pushProviders
     }