Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/landscape #68

Merged
merged 14 commits into from
Oct 16, 2023
Merged

Feature/landscape #68

merged 14 commits into from
Oct 16, 2023

Conversation

PavloNetrebchuk
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk commented Oct 5, 2023 •
edited
Loading

Landscape support for full application

Screenshot 2023-10-12 at 19 47 25

Screenshot 2023-10-12 at 19 50 34

Screenshot 2023-10-12 at 19 49 53

Screenshot 2023-10-12 at 19 52 07

Screenshot 2023-10-12 at 19 52 51

@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/landscape_screens branch 2 times, most recently from 271695a to 1a577cc Compare October 6, 2023 10:28
@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/landscape_screens branch from 1a577cc to aa65582 Compare October 6, 2023 12:29
@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/landscape_screens branch 3 times, most recently from bf60520 to c1b3575 Compare October 9, 2023 09:39
@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/landscape_screens branch from c1b3575 to 637d888 Compare October 9, 2023 14:00
@volodymyr-chekyrta volodymyr-chekyrta changed the title Feature/landscape screens Feature/landscape Oct 10, 2023
@volodymyr-chekyrta volodymyr-chekyrta linked an issue Oct 10, 2023 that may be closed by this pull request
Landscape support [Android] #62
Closed
@PavloNetrebchuk
Remembers if the video was playing before the screen was rotated or w…
e39b8ad 
…hen opening/closing full screen mode and restore that state
@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/landscape_screens branch from 43a55ca to e39b8ad Compare October 10, 2023 13:05
@marcotuts
Copy link
Contributor

Thanks for the update here, will get back to you asap on some suggested minor changes that will either be in this PR or a follow-on PR.

@sdaitzman
Copy link

sdaitzman commented Oct 11, 2023 •
edited
Loading

This looks great! Here are some mocks with slight proposed design changes to the landscape "Good work!" dialog and video-with-transcript views. Edit: updated with similar proposed changes for portrait mode "Good work!" dialogs and web-view blocks

image
image

The landscape video-with-transcript and webview components can reposition the back button, title, and next/previous buttons in a unified bar at the top, and use the extra space to expand the video and transcript

image
image

The “Good work!” dialog has an added dismiss button to allow users to continue viewing the section before moving on

@sdaitzman sdaitzman mentioned this pull request Oct 11, 2023
Merged
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 11, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 11, 2023 •
edited
Loading

Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211
Copy link

Hi @PavloNetrebchuk! If you are contributing on behalf of Raccoon Gang, please have your manager email [email protected] in order to add you to the existing Raccoon Gang entity CLA form. Thank you!

@PavloNetrebchuk
Copy link
Contributor Author

PavloNetrebchuk commented Oct 12, 2023 •
edited
Loading

Hello @marcotuts @sdaitzman !
I have made changes and added new screenshots in the description

@sdaitzman
Copy link

Thanks for the update, I think this looks good and addresses the suggested changes we identified!

In this screenshot, if the phone is rotated 180˚ so the camera is on the right, will it overlap with the progress dots on the right, or are they positioned to adjust within the safe area?

@PavloNetrebchuk
Copy link
Contributor Author

@sdaitzman
Yes, it overlap with the progress dots
IMG_20231012_214347

@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/landscape_screens branch from 2e499ac to 2d78cbb Compare October 13, 2023 13:18
@PavloNetrebchuk
Copy link
Contributor Author

@sdaitzman We have resolved the issue 👍
IMG_20231013_162229

marcotuts
marcotuts approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@marcotuts marcotuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product review complete - thanks!

@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/landscape_screens branch 2 times, most recently from 3e2ac4c to 4ac6962 Compare October 13, 2023 16:06
@PavloNetrebchuk
Merge remote-tracking branch 'origin/develop' into feature/landscape_…
1b28b98 
…screens

# Conflicts:
#	course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt
#	discussion/src/main/java/org/openedx/discussion/presentation/responses/DiscussionResponsesFragment.kt
@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/landscape_screens branch from 4ac6962 to 1b28b98 Compare October 16, 2023 09:19
@volodymyr-chekyrta volodymyr-chekyrta merged commit 495c1bd into openedx:develop Oct 16, 2023
1 check passed
@openedx-webhooks
Copy link

@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/landscape_screens branch October 16, 2023 13:34
k1rill pushed a commit to touchapp/openedx-app-android that referenced this pull request Dec 11, 2024
@HamzaIsrar12
refactor: Enhance Social Authentication on Sign In and Sign Up Screens (
41fd982 
openedx#68)

- Update resource files
- Store last sign in type in preferences
- Fix Sign-In Success Analytics
- Improve the social auth view
- Fix Auth Test Cases
- Update doc string

Fixes: LEARNER-10256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

@marcotuts marcotuts marcotuts approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Landscape support [Android]
6 participants
@PavloNetrebchuk @marcotuts @sdaitzman @openedx-webhooks @mphilbrick211 @volodymyr-chekyrta