Skip to content
This repository was archived by the owner on Feb 14, 2025. It is now read-only.

fix: simple editor without solution not loading - #489

Merged
KristinAoki merged 11 commits into
mainfrom
KristinAoki/fix-new-simple-problem-load
Jun 27, 2024
Merged

fix: simple editor without solution not loading#489
KristinAoki merged 11 commits into
mainfrom
KristinAoki/fix-new-simple-problem-load

Conversation

@KristinAoki

Copy link
Copy Markdown
Contributor

This PR resolves the problem editor not load new simple problems and reimplements the changes in #484

Testing

  1. Create a new problem
  2. Select a problem type
  3. Confirm that the editor loads
  4. Refresh the page
  5. Repeat 2 through 4 until all simple problems have been tested

@codecov

codecov Bot commented Jun 26, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.32787% with 24 lines in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (dedcb14) to head (f755616).
Report is 14 commits behind head on main.

Files Patch % Lines
...omponents/SelectionModal/GalleryLoadMoreButton.jsx 16.66% 10 Missing ⚠️
...rc/editors/sharedComponents/TinyMceWidget/hooks.js 76.92% 9 Missing ⚠️
src/editors/containers/ProblemEditor/index.jsx 50.00% 1 Missing ⚠️
src/editors/containers/TextEditor/index.jsx 75.00% 1 Missing ⚠️
...ponents/ImageUploadModal/SelectImageModal/hooks.js 85.71% 1 Missing ⚠️
...ditors/sharedComponents/SelectionModal/Gallery.jsx 66.66% 1 Missing ⚠️
...rc/editors/sharedComponents/TinyMceWidget/utils.js 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   89.25%   89.01%   -0.24%     
==========================================
  Files         246      248       +2     
  Lines        4475     4596     +121     
  Branches      917      961      +44     
==========================================
+ Hits         3994     4091      +97     
- Misses        454      474      +20     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesperhodge jesperhodge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited about the performance improvement! That's just a great feature

@KristinAoki
KristinAoki merged commit 2678234 into main Jun 27, 2024
@KristinAoki
KristinAoki deleted the KristinAoki/fix-new-simple-problem-load branch June 27, 2024 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants