Skip to content

Commit 7c1c0d3

Browse files
fix: iframe height for discussions sidebar (#1392)
* fix: iframe height for discussions sidebar * fix: increase adaptation brakepoint
1 parent 37c28b6 commit 7c1c0d3

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
.discussions-sidebar-frame {
2+
@media (max-width: -1 + map-get($grid-breakpoints, "xl")) {
3+
max-height: calc(100vh - 65px);
4+
}
5+
}

src/courseware/course/sidebar/sidebars/discussions/DiscussionsSidebar.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const DiscussionsSidebar = ({ intl }) => {
3232
>
3333
<iframe
3434
src={`${discussionsUrl}?inContextSidebar`}
35-
className="d-flex w-100 h-100 border-0"
35+
className="d-flex w-100 h-100 border-0 discussions-sidebar-frame"
3636
title={intl.formatMessage(messages.discussionsTitle)}
3737
allow="clipboard-write"
3838
loading="lazy"

src/index.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,7 @@
393393

394394
// Import component-specific sass files
395395
@import "courseware/course/celebration/CelebrationModal.scss";
396+
@import "courseware/course/sidebar/sidebars/discussions/Discussions.scss";
396397
@import "courseware/course/sidebar/sidebars/notifications/NotificationIcon.scss";
397398
@import "courseware/course/sequence/lock-paywall/LockPaywall.scss";
398399
@import "shared/streak-celebration/StreakCelebrationModal.scss";
@@ -402,7 +403,7 @@
402403
@import "generic/upgrade-notification/UpgradeNotification.scss";
403404
@import "generic/upsell-bullets/UpsellBullets.scss";
404405
@import "course-home/outline-tab/widgets/ProctoringInfoPanel.scss";
405-
@import "src/course-home/outline-tab/widgets/FlagButton.scss";
406+
@import "course-home/outline-tab/widgets/FlagButton.scss";
406407
@import "course-home/progress-tab/course-completion/CompletionDonutChart.scss";
407408
@import "course-home/progress-tab/grades/course-grade/GradeBar.scss";
408409
@import "courseware/course/course-exit/CourseRecommendations";

0 commit comments

Comments
 (0)