BOM-1015 #20
BOM-1015 #20
Conversation
awais786
force-pushed
the
awais786/BOM-1015
branch
from
0a55b3b to
b9f2d68
Compare
| @@ -58,7 +58,7 @@ class ContentDate(models.Model): | |||
| """ | |||
|
|
|||
| course_id = CourseKeyField(db_index=True, max_length=255) | |||
| policy = models.ForeignKey(DatePolicy) | |||
| policy = models.ForeignKey(DatePolicy, on_delete=models.CASCADE) | |||
There was a problem hiding this comment.
django2 requirement
requirements/base.txt
Outdated
| django-waffle==0.17.0 # via edx-django-utils, edx-drf-extensions | ||
| django==1.11.24 | ||
| django-waffle==0.18.0 # via edx-django-utils, edx-drf-extensions | ||
| django==1.11.26 ; python_version < "3" |
There was a problem hiding this comment.
This isn't correct, so we may need to give up on the upper constraint on Django in base.in and just leave it as Django>=1.11; I don't think there's a good way to get pip-compile to generate what we want here with an environment marker involved (there's an open issue for this). I've updated the BOM-1009 description accordingly.
tox.ini
Outdated
| @@ -37,6 +37,8 @@ norecursedirs = .* docs requirements | |||
| deps = | |||
| django111: Django>=1.11,<2.0 | |||
| django20: Django>=2.0,<2.1 | |||
| django21: Django>=2.1,<2.2 | |||
| django22: Django>=2.2,<2.3 | |||
| -r{toxinidir}/requirements/test.txt | |||
| commands = | |||
| py.test {posargs} | |||
There was a problem hiding this comment.
To output any applicable deprecation warnings, this needs to be updated to python -Wd -m pytest {posargs}.
awais786
force-pushed
the
awais786/BOM-1015
branch
from
215b248 to
9ba4b70
Compare
|
@jmbowman Please check again. |
|
That warning is originating in the edx-opaque-keys package, so it'll need to be updated also. I just created BOM-1017 for that. |
|
This PR depends on this PR for warnings fixes openedx/opaque-keys#111 |
awais786
force-pushed
the
awais786/BOM-1015
branch
3 times, most recently
from
b555d65 to
5ca9f2c
Compare
|
@jmbowman I have waited for opaque-key PR to resolve the warnings but I think its fine to merge this now and update opaque-key version in next PR after resolving the warnings. |
|
Sure, that works for me. |
awais786
force-pushed
the
awais786/BOM-1015
branch
from
d7a5a5b to
cba45f7
Compare
Adding tox for django 2, 2.1, 2.2 under python3.5
Description: Describe in a couple of sentence what this PR adds
JIRA: Link to JIRA ticket
https://openedx.atlassian.net/browse/BOM-1015
Dependencies: dependencies on other outstanding PRs, issues, etc.
Merge deadline: List merge deadline (if any)
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.