-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-73 create pr for edx platform repository (Creating waffle flag for integration towards created_submission in the edx-submission repo) #36235
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @gabrielC1409! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
'username': 'lms', | ||
'password': 'password' | ||
'username': 'gabriel_admin', | ||
'password': 'carvajal1407' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changing?
Description
This pull request introduces several improvements and updates to the xmodule/layer module of the edx-platform repository. The main changes include:
Refactoring of xqueue_interface.py and xqueue_submission.py: The functions for sending and handling responses that a student sends within an exercise created in a course have been optimized. For this, the original functionality of sending the submission to Xqueue was maintained, but for this improvement a Waffle Switch was created, where within the LMS Administration it was possible to create and from the tutor env in the development.py file this environment variable is found pointing to the Switch created in the LMS Administration. This Switch was created within Xqueue_interfaces.py when you want to test or not this new functionality of sending the submit to created_submission.
Unit test update: The tests in test_xqueue_interface.py and test_xqueue_submission.py have been reviewed and updated to ensure compatibility with the new modifications and improve test coverage.
Improvements to helpers.py: Helper functions have been added to facilitate the creation of test environments and the simulation of specific scenarios.
Motivation:
These improvements aim to optimize the performance and maintainability of the XQueue-related code, ensuring a more robust and efficient integration into the evaluation workflow.
Tests performed:
All existing unit tests have been run and new tests have been added to cover the newly introduced cases. All tests have passed satisfactorily.
Additional considerations:
No negative impacts on other parts of the system are anticipated, as the changes are limited to the xmodule/layer module.
Recommendations for review:
A detailed review of the modified functions in xqueue_interface.py and xqueue_submission.py, as well as the new tests added in the corresponding files, is suggested.