Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the sampled efficient zero portion of the code #218

Closed
LiuDongyang39 opened this issue Apr 17, 2024 · 2 comments
Closed

the sampled efficient zero portion of the code #218

LiuDongyang39 opened this issue Apr 17, 2024 · 2 comments
Labels
discussion Discussion of a typical issue or concept enhancement New feature or request

Comments

@LiuDongyang39
Copy link

LiuDongyang39 commented Apr 17, 2024

Hello,I was wondering if the sampled efficient zero portion of the code didn't use the empirical distribution from the original sampledmuzero paper to generate the prior probability of the child nodes?

@LiuDongyang39 LiuDongyang39 changed the title sampled efficient zero部分代码问题 the sampled efficient zero portion of the code Apr 17, 2024
@puyuan1996
Copy link
Collaborator

Hello! We have implemented functionalities related to the empirical distribution as described in the original SampledMuZero paper. You can refer to our ptree and ctree codes for specific implementation details. Please note that since the K actions we sample are non-repetitive, the empirical distribution is essentially a re-normalization of the original probabilities (for discrete action spaces) or log probabilities (for continuous action spaces). As the original author's code is not open source, this implementation is based solely on our understanding. Additionally, following recent discussions on this issue, we plan to optimize the performance of sampled_efficientzero soon. Thank you for your patience and support.

@puyuan1996 puyuan1996 added discussion Discussion of a typical issue or concept enhancement New feature or request labels Apr 18, 2024
@LiuDongyang39
Copy link
Author

LiuDongyang39 commented Apr 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion of a typical issue or concept enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants