Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on arm64 run local sonarqube with latest LTS 9 #712

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

henrjk
Copy link
Member

@henrjk henrjk commented Jul 3, 2023

Closes #711

For the image used in CI the version should be aligned with ODS (see opendevstack/ods-core#1211.)

Tasks:

  • [NA] Updated design documents in docs/design directory or not applicable
  • [NA] Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

@michaelsauter
Copy link
Member

If this works well locally compared to the 9.7 image, I would suggest to merge this in. My understanding of the code change is that it would only change the version for arm64, not on CI. So I do not see an issue with being slightly ahead in terms of versions :)

@henrjk
Copy link
Member Author

henrjk commented Jul 20, 2023

If this works well locally compared to the 9.7 image, I would suggest to merge this in. My understanding of the code change is that it would only change the version for arm64, not on CI. So I do not see an issue with being slightly ahead in terms of versions :)

For CI the PR updates SONAR_SCANNER_VERSION from 4.6.2.* to 4.8.0.* and CNES_REPORT_VERSION from 4.0.0 to 4.2.0I.

While ODS is still at 8.9.

From https://community.sonarsource.com/t/sonarscanner-sonarqube-server-compatibility/85702/2
It’s generally good to upgrade to the latest version of the SonarScanner to benefit from the last bug and security fixes.
SonarScanner 4.8 was actually released when SonarQube 8.9 was still the LTS. You should be able to use it without trouble with your old SonarQube version.

So it seems like it is low risk. I will finalize the PR then

@henrjk henrjk changed the title wip local sonar latest LTS 9 version on arm64 run local sonarqube with latest LTS 9 Jul 21, 2023
@henrjk henrjk marked this pull request as ready for review July 21, 2023 07:49
@henrjk
Copy link
Member Author

henrjk commented Jul 21, 2023

Note that my claim that it works referred to run-sonarqube.sh succeeding.

@henrjk
Copy link
Member Author

henrjk commented Aug 31, 2023

With version 9.8 the default branch was changed to main so that this now fails with:

INFO  | Checking quality gate ...
2023/08/31 14:39:57 quality gate could not be retrieved: request returned unexpected response code: 404, body: {"errors":[{"msg":"Branch \u0027master\u0027 in project \u0027odspipelinetest-workspace-1413872055\u0027 not found"}]}
    helper.go:135: Status: False
    helper.go:136: Reason: Failed
    helper.go:137: Message: "step-scan-with-sonar" exited with code 1 (image: "localhost:5000/ods/ods-sonar@sha256:dccabd704b7ce697b8b21b5acf0a5932d28ebb11b8c279efb0f2c3cf0677334d"); for logs run: kubectl -n rbeeabiq logs ods-build-go-taskrun-wnxtfsmd-pod -c step-scan-with-sonar

One possibility would be if one could configure this so that one can revert back, but at least using sonar.properties this appears not to be supported: Setting default main branch name in sonar.properties

@henrjk henrjk marked this pull request as draft September 1, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run-sonarqube.sh typically not working on apple silicon
2 participants