Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set environment variables for build tasks? #564

Closed
michaelsauter opened this issue Jun 15, 2022 · 1 comment
Closed

Allow to set environment variables for build tasks? #564

michaelsauter opened this issue Jun 15, 2022 · 1 comment
Labels
question Further information is requested

Comments

@michaelsauter
Copy link
Member

I'm wondering if we should allow to set environment variables in the build task containers via the Helm chart, in the same way we allow to control the sidecars / resources. This could be used to set env vars needed for testing for example, however often there are other ways of doing this as well so not sure if we really need it.

@michaelsauter michaelsauter added the question Further information is requested label Jun 15, 2022
@michaelsauter
Copy link
Member Author

I'm going to close this. There hasn't been a concrete use case so far, and the general direction would be to try to use central tasks (e.g. from Artefact Hub, see #620) instead of tasks defined in the Helm chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant