Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance customisation options for buildconfig #998

Open
tbugfinder opened this issue Apr 26, 2023 · 3 comments
Open

enhance customisation options for buildconfig #998

tbugfinder opened this issue Apr 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@tbugfinder
Copy link
Contributor

tbugfinder commented Apr 26, 2023

Is your feature request related to a problem? Please describe.
It should be possible to configure buildconfig settings like the memory / cpu limits or buildfrom within odsComponentStageBuildOpenShiftImage.
Currently a developer could tweak those settings once the buildconfig was deployed within an Openshift project.

It would also be beneficial to configure builds for build/execution speed.

Describe the solution you'd like
Add an configuration option to odsComponentStageBuildOpenShiftImage.


spec:
  resources:
    limits:
      cpu: "1" 
      memory: "6Gi"
    requests:
      cpu: "200m"
      memory: "2Gi"

Describe alternatives you've considered

  • manual tweak of initial buildconfig

Additional context

I'm also wondering if the buildconfig couldn't default to e.g. 4 CPUs or 8 CPUs and 8Gi memory. This would improve developer experience a lot and it doesn't harm anything and shouldn't cost too much either in a cloud auto-scaling environment.

@gerardcl
Copy link
Member

I also miss here the config option to set the buildFrom attribute, maybe we could switch this issue to "enhance customisation config options for build stage" ?

@tbugfinder
Copy link
Contributor Author

Could you paste the link to docs and an example?

@tbugfinder tbugfinder changed the title configure cpu/memory limits of buildconfig enhance customisation options for buildconfig Apr 26, 2023
@gerardcl
Copy link
Member

hi @tbugfinder ! sure!

  • docs
  • example would be when locally building postgres but on openshift building with redhat postgres based images etc (in the docs there is a code example)

@braisvq1996 braisvq1996 added the enhancement New feature or request label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants