Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Request: Overwrite default currency #3

Open
cmergenthaler opened this issue Apr 18, 2024 · 4 comments
Open

Feat Request: Overwrite default currency #3

cmergenthaler opened this issue Apr 18, 2024 · 4 comments

Comments

@cmergenthaler
Copy link

cmergenthaler commented Apr 18, 2024

Is your feature request related to a problem? Please describe.
The default currency is USD which is hardcorded in https://github.com/opencost/opencost/blob/develop/ui/src/Reports.js#L128

Describe the solution you'd like
Let us somehow overwrite the default currency by e.g setting an environment variable.
I'd be happy to file a PR if this is an accepted solution

Describe alternatives you've considered
Always needed to change to my local currency from USD is inconvenient.

@mattray
Copy link
Collaborator

mattray commented Apr 19, 2024

That sounds like a nice feature to add. A PR against the UI as an environment variable would make sense. Thanks!

@jash2105
Copy link

@mattray ...can I work on this?

@mattray
Copy link
Collaborator

mattray commented Apr 22, 2024

@jash2105 definitely, we're happy to take PRs. I'll keep an eye out for it

@mattray mattray transferred this issue from opencost/opencost May 23, 2024
@nishikant
Copy link

The currency change just misleading. The drop down to change the currency simply changes the symbol associated with COST and does not apply the conversion rate or ask for conversion rate to apply.

USD 300 != INR 300

OpenCost version: 1.111.0 (7afa352)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants