Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs: migrate away from github.com/apex/log #557

Open
cyphar opened this issue Nov 28, 2024 · 2 comments
Open

logs: migrate away from github.com/apex/log #557

cyphar opened this issue Nov 28, 2024 · 2 comments

Comments

@cyphar
Copy link
Member

cyphar commented Nov 28, 2024

While we picked apex/log because it had nicer formatting than logrus, it seems that apex/log is no longer maintained and we should probably move to something else (if for no other reason than apex/log still uses github.com/pkg/errors wrapping which we stopped using in #556).

@dleviminzi
Copy link

What do you think about moving to https://github.com/rs/zerolog? I'd be happy to assist in the migration.

@cyphar
Copy link
Member Author

cyphar commented Dec 12, 2024

I saw that but wasn't sure if https://github.com/uber-go/zap is better maintained or not (though according to zap themselves, zerolog is faster).

It would be nice to pick something that is going to be maintained for as long as possible so we don't have to do more migrations in the future (logrus wins out on this metric imho).

Also, let me take a look at how the log formatting looks before starting to work on a port 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants