From 5a03d31e737fb9a0ded6bd53d3f31193b800cdcf Mon Sep 17 00:00:00 2001 From: Ma Shimiao Date: Thu, 26 May 2016 17:25:44 +0800 Subject: [PATCH] validate/env: add env name begins with digit check Signed-off-by: Ma Shimiao --- validate.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/validate.go b/validate.go index 71837345f..cfc3b9f87 100644 --- a/validate.go +++ b/validate.go @@ -266,10 +266,13 @@ func envValid(env string) bool { if len(items) < 2 { return false } - for _, ch := range strings.TrimSpace(items[0]) { + for i, ch := range strings.TrimSpace(items[0]) { if !unicode.IsDigit(ch) && !unicode.IsLetter(ch) && ch != '_' { return false } + if i == 0 && unicode.IsDigit(ch) { + logrus.Warnf("Env %v: variable name beginning with digit is not recommended.", env) + } } return true }