Skip to content

Conversation

@zhouhao3
Copy link

Signed-off-by: zhouhao [email protected]

@TomSweeneyRedHat
Copy link

For posterity sake, it would be nice to have a more detailed submit message. Perhaps: "config-solaris: Replaced refs with actual fields in cappedCPU, cappedMemory and anet fields"

@zhouhao3 zhouhao3 changed the title config-solaris: Fill field config-solaris: Replaced refs with actual fields in cappedCPU, cappedMemory and anet fields Jul 13, 2017
@zhouhao3
Copy link
Author

zhouhao3 commented Aug 1, 2017

@dqminh @tianon @crosbymichael PTAL

@crosbymichael
Copy link
Member

crosbymichael commented Aug 1, 2017

LGTM

Approved with PullApprove

@zhouhao3
Copy link
Author

zhouhao3 commented Aug 3, 2017

ping @hqhq

@hqhq
Copy link
Contributor

hqhq commented Aug 14, 2017

LGTM

Approved with PullApprove

@hqhq hqhq merged commit 49c255e into opencontainers:master Aug 14, 2017
@zhouhao3 zhouhao3 deleted the solaris-fix branch August 14, 2017 02:16
@vbatts vbatts mentioned this pull request Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants