Fix type of devices type #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I found the example of |
Member
|
I think we should change it from rune to string so that you can actually write "b", "c" in the json spec and you can easily know what type of device it is. What do you think? |
Contributor
|
+1 for switching to |
Contributor
|
On Mon, Feb 22, 2016 at 11:32:06AM -0800, Vish Kannan wrote:
ditto |
hqhq
force-pushed
the
hq_fix_devices_example
branch
from
e614748 to
96c5ff0
Compare
Contributor
Author
|
Updated, thanks. |
Contributor
Fixes: opencontainers/runc#566 For type rune, we can assign char as 'c' in struct, but after marshal, it'll be presented as int32. So in json config it needs to be presented as a number which is not friendly to be identified. Change it to string so that you can actually write "b", "c" in json spec and you can easily know what type of device it is. Signed-off-by: Qiang Huang <[email protected]>
In json, os.FileMode would be presented as a uint32, which is decimal. Otherwise we'll get error: `invalid character '6' after object key:value pair` when unmarshal the json file. Signed-off-by: Qiang Huang <[email protected]>
hqhq
force-pushed
the
hq_fix_devices_example
branch
from
96c5ff0 to
ccf3a24
Compare
Contributor
Author
|
@wking Using quotes so people know that's a |
Contributor
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: opencontainers/runc#566
For type rune, we can assign char as 'c' in struct, but after
marshal, it'll be presented as int32. So it should be a
number in our example of json file. Otherwise we'll got error:
json: cannot unmarshal string into Go value of type int32If we trying to unmarshal the json file.
Signed-off-by: Qiang Huang [email protected]