Skip to content

Commit 3715b4c

Browse files
committed
specs-go/config: Make User.UID and User.GID pointers
Avoiding: $ go test ./specs-go --- FAIL: TestConfigRoundTrip (0.00s) --- FAIL: TestConfigRoundTrip/config_2 (0.00s) round_trip_test.go:35: failed to round-trip: {"ociVersion":"1.0.0","platform":{"os":"windows","arch":"amd64"},"process":{"user":{"uid":0,"gid":0,"username":"containeradministrator"},"args":["sh"],"cwd":"C:\\"},"root":{"path":"rootfs"}} FAIL FAIL github.com/opencontainers/runtime-spec/specs-go 0.003s We can't just add omitempty (without also making them pointers), because 0 is a meaningful value for both properties. Signed-off-by: W. Trevor King <[email protected]>
1 parent 2c17c87 commit 3715b4c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

specs-go/config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ type Box struct {
8282
// User specifies specific user (and group) information for the container process.
8383
type User struct {
8484
// UID is the user id.
85-
UID uint32 `json:"uid" platform:"linux,solaris"`
85+
UID *uint32 `json:"uid,omitempty" platform:"linux,solaris"`
8686
// GID is the group id.
87-
GID uint32 `json:"gid" platform:"linux,solaris"`
87+
GID *uint32 `json:"gid,omitempty" platform:"linux,solaris"`
8888
// AdditionalGids are additional group ids set for the container's process.
8989
AdditionalGids []uint32 `json:"additionalGids,omitempty" platform:"linux,solaris"`
9090
// Username is the user name.

0 commit comments

Comments
 (0)