[1.4] rootfs: only set mode= for tmpfs mount if target already existed #4976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
force-pushed
the
1.4-tmpfs-mode
branch
from
f32d284 to
152a2b9
Compare
This was always the intended behaviour but commit 72fbb34 ("rootfs: switch to fd-based handling of mountpoint targets") regressed it when adding a mechanism to create a file handle to the target if it didn't already exist (causing the later stat to always succeed). A lot of people depend on this functionality, so add some tests to make sure we don't break it in the future. Fixes: 72fbb34 ("rootfs: switch to fd-based handling of mountpoint targets") Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit 9a9719e) Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
1.4-tmpfs-mode
branch
from
152a2b9 to
fbf9e99
Compare
kolyshkin
approved these changes
Nov 11, 2025
lifubang
approved these changes
Nov 11, 2025
Merged
Merged
Xeeynamo
added a commit
to Xeeynamo/moby
that referenced
this pull request
Dec 1, 2025
- release notes: https://github.com/opencontainers/runc/releases/tag/v1.3.4 - full diff: opencontainers/[email protected] This version bump aims to fix a regression in runc v1.3.3, which caused /dev/shm to have inappropriate permissions exposed to containers: * opencontainers/runc#4971 * opencontainers/runc#4976
Xeeynamo
added a commit
to Xeeynamo/moby
that referenced
this pull request
Dec 1, 2025
- release notes: https://github.com/opencontainers/runc/releases/tag/v1.3.4 - full diff: opencontainers/[email protected] This version bump aims to fix a regression in runc v1.3.3, which caused /dev/shm to have inappropriate permissions exposed to containers: * opencontainers/runc#4971 * opencontainers/runc#4976 Signed-off-by: Luciano Ciccariello <[email protected]>
Xeeynamo
added a commit
to Xeeynamo/moby
that referenced
this pull request
Dec 1, 2025
- release notes: https://github.com/opencontainers/runc/releases/tag/v1.4.0 - full diff: opencontainers/[email protected] This version bump aims to fix a regression in runc v1.3.3, which caused /dev/shm to have inappropriate permissions exposed to containers: * opencontainers/runc#4971 * opencontainers/runc#4976 Signed-off-by: Luciano Ciccariello <[email protected]>
Xeeynamo
added a commit
to Xeeynamo/moby
that referenced
this pull request
Dec 2, 2025
- release notes: https://github.com/opencontainers/runc/releases/tag/v1.4.0 - full diff: opencontainers/[email protected] This version bump aims to fix a regression in runc v1.3.3, which caused /dev/shm to have inappropriate permissions exposed to containers: * opencontainers/runc#4971 * opencontainers/runc#4976 Signed-off-by: Luciano Ciccariello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4973.
(Draft until merged.)This was always the intended behaviour but commit 72fbb34 ("rootfs:
switch to fd-based handling of mountpoint targets") regressed it when
adding a mechanism to create a file handle to the target if it didn't
already exist (causing the later stat to always succeed).
A lot of people depend on this functionality, so add some tests to make
sure we don't break it in the future.
Fixes #4971
Fixes: 72fbb34 ("rootfs: switch to fd-based handling of mountpoint targets")
Signed-off-by: Aleksa Sarai [email protected]