Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT:replace github.com/syndtr/gocapability with github.com/kolyshkin/capa… #4362

Closed

Conversation

ningmingxiao
Copy link

fix: #4356

@rata
Copy link
Member

rata commented Jul 31, 2024

Several tests are failing. Is this ready?

@kolyshkin do you want to maintain it? Do you want to use a git commit or maybe a release tag?

@kolyshkin
Copy link
Contributor

@kolyshkin do you want to maintain it?

Yes, I took that (brave) decision last week and am preparing a release. Once ready, I will open a PR here.

By the way, the CI failures here are legit -- I just found out that my fix (kolyshkin/capability#3) revealed the inability to set ambient caps. The error (EPERM from was previously ignored because the code that introduced ambient caps support was ignoring any errors from prctl(PR_CAP_AMBIENT. I have yet to figure out how to fix this (without ignoring any errors, that is).

@ningmingxiao you can work on other things.

@rata
Copy link
Member

rata commented Aug 1, 2024

@kolyshkin awesome! Do you want to keep the repo under your user or...? Vendor here or something else?

Can we switch this to draft (or close it) and mark it as ready for review when it is ready for review?

@ningmingxiao ningmingxiao changed the title replace github.com/syndtr/gocapability with github.com/kolyshkin/capa… DRAFT:replace github.com/syndtr/gocapability with github.com/kolyshkin/capa… Aug 1, 2024
@kolyshkin
Copy link
Contributor

I have yet to figure out how to fix this (without ignoring any errors, that is).

Opened #4367.

@kolyshkin awesome! Do you want to keep the repo under your user or...? Vendor here or something else?

Can we switch this to draft (or close it) and mark it as ready for review when it is ready for review?

Let's close this one and continue in #4358.

@kolyshkin kolyshkin closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runc aways open "/proc/sys/kernel/cap_last_cap"
3 participants