Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.1.5 (Fix CVE-2023-27561, CVE-2023-25809, CVE-2023-28642) #3789

Closed
AkihiroSuda opened this issue Mar 28, 2023 · 8 comments
Closed
Milestone

Comments

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Mar 28, 2023

We have to release v1.1.5 to fix:

@AkihiroSuda AkihiroSuda added this to the 1.1.5 milestone Mar 28, 2023
@AkihiroSuda
Copy link
Member Author

@cyphar Could you / Can I (or any maintainer) make the release?

@AkihiroSuda AkihiroSuda changed the title Release v1.1.5 (CVE-2023-27561, CVE-2023-25809) Release v1.1.5 (Fix CVE-2023-27561, CVE-2023-25809) Mar 28, 2023
@kolyshkin
Copy link
Contributor

I think we can postpone fixing #3715 to 1.1.6, so that we could release 1.1.5 faster.

@kolyshkin
Copy link
Contributor

I will prepare a changelog.

@kolyshkin
Copy link
Contributor

@cyphar it would be great if @AkihiroSuda or me could make a release.

@AkihiroSuda here's a draft of a changelog, not including a line for GHSA-m8cg-xc2p-r3fc. Feel free to use as is or modify.

## [1.1.5] - 2023-04-XX

> FIXME

### Fixed

* Prohibit container's `/proc` and `/sys` to be symlinks (CVE-2019-19921,
  CVE-2023-27561, #3785)
* Fix the inability to use `/dev/null` when inside a container. (#3620)
* Fix changing the ownership of host's `/dev/null` caused by fd redirection
  (a regression in 1.1.1). (#3674, #3731)
* Fix rare runc exec/enter unshare error on older kernels, inlcuding
  CentOS < 7.7. (#3776)
* nsexec: Check for errors in `write_log()`. (#3721)
* Various CI fixes and updates. (#3618, #3630, #3640, #3729)

@AkihiroSuda AkihiroSuda changed the title Release v1.1.5 (Fix CVE-2023-27561, CVE-2023-25809) Release v1.1.5 (Fix CVE-2023-27561, CVE-2023-25809, CVE-2023-*****) Mar 28, 2023
@AkihiroSuda AkihiroSuda changed the title Release v1.1.5 (Fix CVE-2023-27561, CVE-2023-25809, CVE-2023-*****) Release v1.1.5 (Fix CVE-2023-27561, CVE-2023-25809, CVE-2023-28642) Mar 28, 2023
@cyphar
Copy link
Member

cyphar commented Mar 29, 2023

I will do the release. We discussed making a runc.keyring file for this (so packagers use that rather than depending on my keyring), I can set that up later.

@cyphar
Copy link
Member

cyphar commented Mar 29, 2023

@hqhq pressed the merge button for GHSA-m8cg-xc2p-r3fc, so I'll just push everything now.

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Mar 29, 2023

CI began to fail for Ubuntu 🤦
0d62b95
https://github.com/opencontainers/runc/actions/runs/4550888689/jobs/8024349935

not ok 94 runc run [ro /sys/fs/cgroup mount]
# (in test file tests/integration/mounts.bats, line 74)
#   `for line in "${lines[@]}"; do [[ "${line}" == *'ro,'* ]]; done' failed
# runc spec --rootless (status=0):
# 
# runc run test_busybox (status=0):
# cgroup /sys/fs/cgroup/rdma cgroup ro,nosuid,nodev,noexec,relatime,rdma 0 0
# cgroup2 /sys/fs/cgroup/unified cgroup2 rw,nosuid,nodev,noexec,relatime,nsdelegate 0 0
# cgroup /sys/fs/cgroup/systemd cgroup ro,nosuid,nodev,noexec,relatime,xattr,name=systemd 0 0
# cgroup /sys/fs/cgroup/net_cls,net_prio cgroup ro,nosuid,nodev,noexec,relatime,net_cls,net_prio 0 0
# cgroup /sys/fs/cgroup/devices cgroup ro,nosuid,nodev,noexec,relatime,devices 0 0
# cgroup /sys/fs/cgroup/memory cgroup ro,nosuid,nodev,noexec,relatime,memory 0 0
# cgroup /sys/fs/cgroup/freezer cgroup ro,nosuid,nodev,noexec,relatime,freezer 0 0
# cgroup /sys/fs/cgroup/hugetlb cgroup ro,nosuid,nodev,noexec,relatime,hugetlb 0 0
# cgroup /sys/fs/cgroup/cpu,cpuacct cgroup ro,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0
# cgroup /sys/fs/cgroup/misc cgroup ro,nosuid,nodev,noexec,relatime,misc 0 0
# cgroup /sys/fs/cgroup/cpuset cgroup ro,nosuid,nodev,noexec,relatime,cpuset 0 0
# cgroup /sys/fs/cgroup/perf_event cgroup ro,nosuid,nodev,noexec,relatime,perf_event 0 0
# cgroup /sys/fs/cgroup/pids cgroup ro,nosuid,nodev,noexec,relatime,pids 0 0
# cgroup /sys/fs/cgroup/blkio cgroup ro,nosuid,nodev,noexec,relatime,blkio 0 0
# cgroup /sys/fs/cgroup/rdma cgroup ro,nosuid,nodev,noexec,relatime,rdma 0 0
# cgroup /sys/fs/cgroup/rdma cgroup ro,nosuid,nodev,noexec,relatime,rdma 0 0
# cgroup /sys/fs/cgroup/systemd cgroup ro,nosuid,nodev,noexec,relatime,xattr,name=systemd 0 0
# cgroup /sys/fs/cgroup/net_cls,net_prio cgroup ro,nosuid,nodev,noexec,relatime,net_cls,net_prio 0 0
# cgroup /sys/fs/cgroup/devices cgroup ro,nosuid,nodev,noexec,relatime,devices 0 0
# cgroup /sys/fs/cgroup/memory cgroup ro,nosuid,nodev,noexec,relatime,memory 0 0
# cgroup /sys/fs/cgroup/freezer cgroup ro,nosuid,nodev,noexec,relatime,freezer 0 0
# cgroup /sys/fs/cgroup/hugetlb cgroup ro,nosuid,nodev,noexec,relatime,hugetlb 0 0
# cgroup /sys/fs/cgroup/cpu,cpuacct cgroup ro,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0
# cgroup /sys/fs/cgroup/misc cgroup ro,nosuid,nodev,noexec,relatime,misc 0 0
# cgroup /sys/fs/cgroup/cpuset cgroup ro,nosuid,nodev,noexec,relatime,cpuset 0 0
# cgroup /sys/fs/cgroup/perf_event cgroup ro,nosuid,nodev,noexec,relatime,perf_event 0 0
# cgroup /sys/fs/cgroup/pids cgroup ro,nosuid,nodev,noexec,relatime,pids 0 0
# cgroup /sys/fs/cgroup/blkio cgroup ro,nosuid,nodev,noexec,relatime,blkio 0 0
# cgroup /sys/fs/cgroup/rdma cgroup ro,nosuid,nodev,noexec,relatime,rdma 0 0

Passing for Fedora though.

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Mar 29, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants