Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup/systemd func systemdProperties sets wrong char entry.Path #3567

Closed
yangfeiyu20102011 opened this issue Aug 23, 2022 · 4 comments
Closed

Comments

@yangfeiyu20102011
Copy link

case devices.CharDevice: 
entry.Path = fmt.Sprintf("/dev/char/%d:%d", rule.Major, rule.Minor)

This may set wrong char entry.Path when comes with NVIDIA devices, and it will set
DeviceAllow=/dev/char/195:0 rw in systemd DeviceAllow.conf. It will not work.

@yangfeiyu20102011
Copy link
Author

#3568 will fix it.

@kolyshkin
Copy link
Contributor

Duplicate of #3671

@kolyshkin kolyshkin marked this as a duplicate of #3671 Apr 26, 2023
@kolyshkin kolyshkin closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2023
@kolyshkin kolyshkin marked this as not a duplicate of #3671 Apr 26, 2023
@kolyshkin
Copy link
Contributor

OK this is not a duplicate but a different issue.

This was fixed in system v240, if you're using an earlier version, there is nothing you can do about it.

I also heard that nvidia is going to fix it in their drivers, so that the proper /dev/... nodes will be created (which will help with older systemd).

@kolyshkin kolyshkin reopened this Apr 26, 2023
@kolyshkin
Copy link
Contributor

For some details about why systemd v240 is needed, see the description of #3842

So, there's nothing we can do when older systemd is used, and in case systemd is >= v240, you either need runc < 1.1.3 or >= 1.1.7 (not yet released), or the one built from the main branch (after merging #3842).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants