Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake TestFreezeBeforeSet on CentOS 7 and 8 #3540

Open
kolyshkin opened this issue Jul 28, 2022 · 9 comments · May be fixed by #4442
Open

flake TestFreezeBeforeSet on CentOS 7 and 8 #3540

kolyshkin opened this issue Jul 28, 2022 · 9 comments · May be fixed by #4442
Labels

Comments

@kolyshkin
Copy link
Contributor

Happened once in Cirrus CI (https://cirrus-ci.com/task/5418288451682304?logs=unit_tests#L549) while running CI for #3512

=== RUN   TestFreezeBeforeSet
=== RUN   TestFreezeBeforeSet/slice,skip-devices
    freeze_test.go:171: failed to write "0\n": write /sys/fs/cgroup/cpuset/system.slice/system-runc_test_freeze_1.slice/cpuset.mems: no such device
=== RUN   TestFreezeBeforeSet/scope,skip-devices
=== RUN   TestFreezeBeforeSet/slice,will-freeze
=== RUN   TestFreezeBeforeSet/slice,pre-frozen,will-freeze
=== RUN   TestFreezeBeforeSet/scope,pre-frozen,skip-devices
=== RUN   TestFreezeBeforeSet/scope,pre-frozen
--- FAIL: TestFreezeBeforeSet (0.41s)
    --- FAIL: TestFreezeBeforeSet/slice,skip-devices (0.06s)
    --- PASS: TestFreezeBeforeSet/scope,skip-devices (0.07s)
    --- PASS: TestFreezeBeforeSet/slice,will-freeze (0.07s)
    --- PASS: TestFreezeBeforeSet/slice,pre-frozen,will-freeze (0.06s)
    --- PASS: TestFreezeBeforeSet/scope,pre-frozen,skip-devices (0.09s)
    --- PASS: TestFreezeBeforeSet/scope,pre-frozen (0.05s)

I've seen similar bugs but not this one. Filing just to ensure it's not lost.

@kolyshkin
Copy link
Contributor Author

In general we seem to have a problem with disappearing cgroups on CentOS 7, e.g. from https://cirrus-ci.com/task/5772431724904448 (while testing #3379):

=== RUN   TestPodSkipDevicesUpdate
    systemd_test.go:86: failed to write 6485: write /sys/fs/cgroup/cpuset/system.slice/system-runc_test_podTestPodSkipDevicesUpdate.slice/test-PodSkipDevicesUpdate.scope/cgroup.procs: no such device
--- FAIL: TestPodSkipDevicesUpdate (0.75s)

@kolyshkin
Copy link
Contributor Author

See also #3351

@kolyshkin
Copy link
Contributor Author

Similar but a different test:

=== RUN   TestSkipDevicesFalse
time="2022-08-08T20:52:16Z" level=info msg="thaw container after SetUnitProperties failed: open /sys/fs/cgroup/freezer/system.slice/system-runc_test_pods.slice/freezer.state: no such file or directory"
    systemd_test.go:187: failed to write 6493: open /sys/fs/cgroup/net_cls,net_prio/system.slice/system-runc_test_pods.slice/test-SkipDevices.scope/cgroup.procs: no such file or directory
--- FAIL: TestSkipDevicesFalse (0.25s)

@kolyshkin
Copy link
Contributor Author

Happened again (https://cirrus-ci.com/task/4792862578573312):

=== RUN   TestSkipDevicesFalse
    systemd_test.go:136: read /sys/fs/cgroup/cpuset/system.slice/system-runc_test_pods.slice/cpuset.mems: no such device
--- FAIL: TestSkipDevicesFalse (0.13s)

@kolyshkin
Copy link
Contributor Author

Happened again, this time on CentOS Stream 8 (https://cirrus-ci.com/task/4931391389958144)

=== RUN   TestFreezeBeforeSet/slice,will-freeze
    freeze_test.go:170: failed to write "0-3\n": write /sys/fs/cgroup/cpuset/system.slice/system-runc_test_freeze_3.slice/cpuset.cpus: no such device
=== RUN   TestFreezeBeforeSet/slice,pre-frozen,will-freeze
=== RUN   TestFreezeBeforeSet/scope,pre-frozen,skip-devices
=== RUN   TestFreezeBeforeSet/scope,pre-frozen
--- FAIL: TestFreezeBeforeSet (0.14s)
    --- PASS: TestFreezeBeforeSet/slice,skip-devices (0.01s)
    --- PASS: TestFreezeBeforeSet/scope,skip-devices (0.03s)
    --- FAIL: TestFreezeBeforeSet/slice,will-freeze (0.01s)
    --- PASS: TestFreezeBeforeSet/slice,pre-frozen,will-freeze (0.01s)
    --- PASS: TestFreezeBeforeSet/scope,pre-frozen,skip-devices (0.05s)
    --- PASS: TestFreezeBeforeSet/scope,pre-frozen (0.01s)

@kolyshkin kolyshkin changed the title TestFreezeBeforeSet on CentOS 7 flake TestFreezeBeforeSet on CentOS 7 and 8 Nov 2, 2022
@kolyshkin
Copy link
Contributor Author

Another failure on CentOS 7:

=== RUN   TestFreezeBeforeSet/slice,skip-devices
    freeze_test.go:170: open /sys/fs/cgroup/cpuset/system.slice/cpuset.cpus: no such file or directory
=== RUN   TestFreezeBeforeSet/scope,skip-devices
=== RUN   TestFreezeBeforeSet/slice,will-freeze
=== RUN   TestFreezeBeforeSet/slice,pre-frozen,will-freeze
=== RUN   TestFreezeBeforeSet/scope,pre-frozen,skip-devices
=== RUN   TestFreezeBeforeSet/scope,pre-frozen
--- FAIL: TestFreezeBeforeSet (0.32s)
    --- FAIL: TestFreezeBeforeSet/slice,skip-devices (0.08s)
    --- PASS: TestFreezeBeforeSet/scope,skip-devices (0.05s)
    --- PASS: TestFreezeBeforeSet/slice,will-freeze (0.05s)
    --- PASS: TestFreezeBeforeSet/slice,pre-frozen,will-freeze (0.04s)
    --- PASS: TestFreezeBeforeSet/scope,pre-frozen,skip-devices (0.06s)
    --- PASS: TestFreezeBeforeSet/scope,pre-frozen (0.04s)

@kolyshkin
Copy link
Contributor Author

The last one is more interesting as it's really hard to imagine how /sys/fs/cgroup/cpuset/system.slice/cpuset.cpus can ever be non-existent.

@tomaszduda23
Copy link

The last one is more interesting as it's really hard to imagine how /sys/fs/cgroup/cpuset/system.slice/cpuset.cpus can ever be non-existent.

You could mount cgroup with noprefix to make it non-exist. See #4443

@kolyshkin
Copy link
Contributor Author

The last one is more interesting as it's really hard to imagine how /sys/fs/cgroup/cpuset/system.slice/cpuset.cpus can ever be non-existent.

You could mount cgroup with noprefix to make it non-exist. See #4443

Alas it is different in this case as no one remounts cgroupfs in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants