From @s-urbaniak on September 9, 2016 9:15

logrus is pretty accepted in the ecosystem, and structured logging doesn't
sound too bad. So I am +1 for this.

On Fri, Sep 9, 2016 at 10:46 AM Antonio Murdaca [email protected]
wrote:

$SUBJECT - logrus have various and a nicer way of printing logs to stdout
with the option to specify the log level (which can then be used to
differentiate the validation level in a nicer way).
The current way of embedding stdout in the validation struct isn't as
pretty as it would be by having a nicer logger like logrus.

@s-urbaniak https://github.com/s-urbaniak wdyt?

/cc @vbatts https://github.com/vbatts @stevvooe
https://github.com/stevvooe @philips https://github.com/philips

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
opencontainers/image-spec#288, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAW8MJU_JyunMxpIqA9OehjG4VLw933cks5qoRzqgaJpZM4J41Ei
.

From @xiekeyang on September 9, 2016 10:1

+1

From @runcom on September 9, 2016 10:4

I'll work on this once we reach consensus and figure out all the other issues about errors/warnings when validating an image, I would love to have a table-like document which lists soft and hard requirement for image validation w/o having to go through the whole spec to figure out MUST and SHOULD. Do you guys think it would be nice/useful to have such a document for oci-image-tool?

From @xiekeyang on September 9, 2016 10:16

It is deep related to #234
In which we are also discussing logrus.
opencontainers/image-spec#234 (comment)

From @s-urbaniak on September 9, 2016 10:25

xfref regarding "how to inject the logger": opencontainers/image-spec#234 (comment)

I am in favor of classical dependency injection as per https://peter.bourgon.org/go-best-practices-2016/#program-design.

From @wking on September 9, 2016 15:27

On Fri, Sep 09, 2016 at 03:25:13AM -0700, Sergiusz Urbaniak wrote:

I am in favor of classical dependency injection as per
https://peter.bourgon.org/go-best-practices-2016/#program-design.

I'm ok with including a logger in our types to avoid relying on global
state. But transitioning to logrus could happen in two stages:

• Replace log calls with logrus calls using the global state.
• Replace global-state logging with explicit logger state carried in
  our types.

Both of those can happen independently. The first should be
straightforward and can happen at any time. The latter should
probably happen along with or after we reorganize validation, etc., to
be more library-like.

From @runcom on September 9, 2016 15:29

The latter should
probably happen along with or after we reorganize validation, etc., to
be more library-like.

totally agree on this point