conformance: do not fail on report generation failure #419
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogpeppe
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe,
sudo-bmitch and
vbatts
as code owners
When the conformance test package cannot write to the current directory, it calls `log.Fatal` and exits immediately, making it look like the tests have failed even when they haven't. This can happen when the conformance tests are run without checking out the repository, as in: ``` go test github.com/opencontainers/distribution-spec/conformance ``` which is possible (and useful) when using the conformance tests as a dependency in some other module. In this case, the files are in a read-only directory inside `$GOMODCACHE`. This change makes the failure soft, so it will print a warning, but not actually fail the tests. This matches the behaviour of `reporters.NewJUnitReporter`. Signed-off-by: Roger Peppe <[email protected]>
rogpeppe
force-pushed
the
001-no-fail-on-no-report
branch
from
93f57a6 to
caded17
Compare
sudo-bmitch
approved these changes
May 27, 2023
jonjohnsonjr
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the conformance test package cannot write to the current directory, it calls
log.Fataland exits immediately, making it look like the tests have failed even when they haven't.This can happen when the conformance tests are run without checking out the repository, as in:
which is possible (and useful) when using the conformance tests as a dependency in some other module. In this case, the files are in a read-only directory inside
$GOMODCACHE.This change makes the failure soft, so it will print a warning, but not actually fail the tests. This matches the behaviour of
reporters.NewJUnitReporter.