Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os.proto Install RPC #37

Closed
Reshad-Rahman opened this issue Apr 21, 2020 · 1 comment · Fixed by #90
Closed

os.proto Install RPC #37

Reshad-Rahman opened this issue Apr 21, 2020 · 1 comment · Fixed by #90

Comments

@Reshad-Rahman
Copy link

https://github.com/openconfig/gnoi/blob/master/os/os.proto#L35 mentions how the target device must proactively manage disk space. However it is difficult to guarantee that the target always has enough space if the space required is unknown. As new products mature, image size often increases. Also some products may have multiple OS images. So to make this more predictable, could the file size be included in the TransferRequest message?

@samribeiro
Copy link
Member

Hi Reshad-Rahman. I believe the system is still predictable? If during the transfer, the Target runs out of space, it must return error with InstallError TOO_LARGE. The Target software should always A) try to have enough space for new OSs, regardless of a potential heads up message stating the incoming OS file size. The only thing this message would save woud be the time attempting the eventually failed transfer. This seems however unimportant, and given A) redundant with unnecessary complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants