Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

oc-template-react without data provider (server.js) #168

Open
nickbalestra opened this issue Mar 9, 2018 · 0 comments
Open

oc-template-react without data provider (server.js) #168

nickbalestra opened this issue Mar 9, 2018 · 0 comments
Labels

Comments

@nickbalestra
Copy link
Contributor

At the moment we always wrap the react app within the hoc provider even if the component doesn't have a data configured in the package.json (no server.js case). The provider to work need a serverless function to be present as we enhance it for them to seamless work together.
In the case where no server is defined such contract break and there is no point in wrapping the app with the provider at that point, although one might want to be abler to ship a react application that doesn't need a serverless function with it.

Suggested solution:
Don't wrap at compile time the react app with the provider in case there is no data defined in the package.json of the component

@jrolfs jrolfs changed the title Oc-template-react without data provider (server.js) oc-template-react without data provider (server.js) Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant