Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we smooth the xgboost model #124

Open
peterdudfield opened this issue May 30, 2024 · 7 comments
Open

Should we smooth the xgboost model #124

peterdudfield opened this issue May 30, 2024 · 7 comments
Labels
good first issue Good for newcomers

Comments

@peterdudfield
Copy link
Contributor

The current xgboost model is quite spike.
This is likely due to the ML learning model

It might be worth smooething this? And we probably need to make sure we smooth this before the night time filter

You can see this here
Screenshot 2024-05-30 at 15 31 35

@peterdudfield peterdudfield added the good first issue Good for newcomers label May 30, 2024
@Plomo-02
Copy link

hello, can I be assigned to this issue?

@froukje
Copy link
Collaborator

froukje commented May 31, 2024

We have been looking into this issue and we think that the reason why the predictions are so spiky is because we download input data for every 15 minutes and use these for predictions. Using hourly data results in much smoother plots. Here is an example. I'm not sure if smoothing would be an appropriate approach here or, when you want the plots/results less spiky we can simply use lower frequency data. The model might not be optimal for this higher frequency as it was trained on hourly data.

Screenshot from 2024-05-31 13-27-04

@peterdudfield
Copy link
Contributor Author

Hi @froukje

If it was trained on hourly data, should probably use hourly data in inference as well. I would probably go for that fix first.
Are you able to make a PR for this?
Thanks

@peterdudfield
Copy link
Contributor Author

hello, can I be assigned to this issue?

Thanks @Plomo-02, its probably best @froukje has a go at this first.

@froukje
Copy link
Collaborator

froukje commented Jun 3, 2024

Yes, sure. No problem.

@froukje
Copy link
Collaborator

froukje commented Jun 6, 2024

This issue can be closed. The predictions have been changed to hourly data.

@aryanbhosale
Copy link
Member

aryanbhosale commented Aug 28, 2024

Can kalman filters be used just before plotting? Even with the 15 min data, it would smoothen the curve - or even PID algorithm, it would minimize the large spikes caused by any noise in the pv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants