LA Metro: Skip attachments that are not visible in the web interface #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Logic to the Metro bill scraper to skip attachments if
MatterAttachmentShowOnInternetPageis False. It would probably be ideal to handle this similarly to the way we do bills, i.e., scrape a record of the attachment but don't scrape any metadata or show in the user interface, but there is an immediate need to suppress an attachment on the live site, and this is the fastest way to achieve it, for now.Testing instructions
pupa update --scrape lametro bills matter_ids=7212