Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definitively remove event time constraint from Metro event pairing #309

Merged
merged 5 commits into from
Jan 14, 2020
Merged

Definitively remove event time constraint from Metro event pairing #309

merged 5 commits into from
Jan 14, 2020

Conversation

hancush
Copy link
Collaborator

@hancush hancush commented Jan 14, 2020 •
edited
Loading

This PR completes the work started in #284, by removing the time constraint from is_partner and partner_search_string when pairing English and Spanish Metro events. It also adds a clarifying comment to an inline assertion and a test for the _merge_events method. It closes #308.

@hancush hancush requested a review from fgregg January 14, 2020 16:01
fgregg
fgregg approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@fgregg fgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. have you done a check to make sure that this matching criterion is not too liberal (i.e. we should only match 0 or 1 other events not more than 1.

@hancush
Copy link
Collaborator Author

hancush commented Jan 14, 2020

@fgregg Great question. I think we try to do that obliquely, but I'll put something more direct in place.

@fgregg
Copy link
Contributor

fgregg commented Jan 14, 2020

maybe an assertion in an appropriate place?

@hancush hancush requested a review from fgregg January 14, 2020 17:16
fgregg
fgregg approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@fgregg fgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @hancush

@hancush hancush merged commit 7cfe8f2 into master Jan 14, 2020
@shrayshray shrayshray mentioned this pull request Feb 8, 2020
Open
@hancush hancush mentioned this pull request Mar 17, 2020
Open
@hancush hancush deleted the feature/hec/metro-event-pairing branch January 28, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgregg fgregg fgregg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EventTime still used for matching spanish and english events for LA Metro
2 participants
@hancush @fgregg