Pin opencivicdata to < 3.0 #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we want to do this here. https://github.com/datamade/scrapers-us-municipal/blob/master/requirements.txt not on this repo. |
|
for this repo, I think it makes sense to open up an issue to fix it up for python-opencivicdata 3.0 |
|
Superseded by #303. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opencivicdataintroduced some breaking changes in 3.0. This PR pins it to the last non-breaking release.The downside of this approach is we'll need to bump this requirement if there are any updates in the 2.x series, which is a departure from our previous practice of installing from master, however given the relative stability/infrequent release history of the OCD code base, I think this should be OK. Plus it ensures that we only upgrade
opencivicdatawhen we we're ready to!