Update pupa clean so that Jurisdiction, Division, and Post objects are not deleted #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hancush
commented
Sep 11, 2024
| @@ -18,7 +18,7 @@ | |||
| entry_points='''[console_scripts] | |||
| pupa = pupa.cli.__main__:main''', | |||
| install_requires=[ | |||
| 'Django>=2.2', | |||
| 'Django>=2.2,<5', | |||
There was a problem hiding this comment.
index_together (used by python-opencivicdata, I guess) was removed in Django 5.
hancush
commented
Sep 11, 2024
Comment on lines
+12
to
+16
| 'NAME': os.getenv('POSTGRES_DB', 'test'), | ||
| 'USER': os.getenv('POSTGRES_USER', 'test'), | ||
| 'PASSWORD': os.getenv('POSTGRES_PASSWORD', 'test'), | ||
| 'HOST': os.getenv('POSTGRES_HOST', 'localhost'), | ||
| 'PORT': os.getenv('POSTGRES_PORT', 5432), |
There was a problem hiding this comment.
Allow for setting these as environment variables, useful for, e.g., if you are running Postgres in a container.
hancush
commented
Sep 11, 2024
| @@ -118,23 +134,25 @@ def test_clean_command_failsafe(subparsers, organization, person): | |||
| for p in stale_people: | |||
| p.memberships.create(organization=organization) | |||
|
|
|||
| cmd = CleanCommand(subparsers) | |||
There was a problem hiding this comment.
pytest complained when this was instantiated multiple times.
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title. Divisions and Posts are unchanging and should not be removed by the
cleancommand!