-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom outputting for pupa data #299
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pass json key file into build)
Custom export update
…date meta data from google pubsub as it is already part of the message object (during subscription)
… client just once in __init__
Google Pub/Sub env var adjustments and helper methods
Custom export amazon sqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if this is a little rough around the edges (not sure what the etiquette is on some of this stuff), but I wanted to submit this as a work-in-progress PR to get feedback.
This PR allows pupa data to be sent to other targets besides being written to a file. This initially includes an output option for Google Cloud Pub/Sub (thanks @showerst for initial implementation), but could also be extended to additional targets/services (e.g., Kafka).
The basic idea is we hook into the
__init__
method of theScraper
class, and set up an instance variableoutput_target
(which defaults toself
for the default file writing). Based on the specifiedOUTPUT_TARGET
environment variable, we call thesave_object
method on either the defaultScraper
instance or the alternative output target instance (e.g., Pub/Sub instance). So the only requirement is to have the alternative output target class implement asave_object
method.So far this works pretty well; however, a couple redundant spots include:
obj.pre_save
callobj.validate()
)obj._related
iterating/savingSeems like some of these could be moved to methods in the
Scraper
class so alternative output target classes wouldn't need to include them.We probably need some unit testing in there as well. Anyway, open to ideas and look forward to getting your feedback. Thanks!