Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make elasticsearch full-text search functional #190

Closed
wants to merge 15 commits into from
Closed

Make elasticsearch full-text search functional #190

wants to merge 15 commits into from

Conversation

mileswwatkins
Copy link
Contributor

Once this is reviewed and accepted, I'll create the index on our Amazon ES cluster.

paultag
paultag reviewed May 26, 2015
View reviewed changes
pupa/utils/fulltext.py
es_bill['subjects'] = bill.subject
es_bill['classifications'] = bill.classification
es_bill['updated_at'] = bill.updated_at.strftime(DATETIME_FORMAT)
es_bill['created_at'] = bill.created_at.strftime(DATETIME_FORMAT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you don't use the inline dict creation here?

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.82%) to 89.16% when pulling 4d7976a on mileswwatkins:miles/feature/fulltext_search into 59c883c on opencivicdata:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.82%) to 89.16% when pulling 4d7976a on mileswwatkins:miles/feature/fulltext_search into 59c883c on opencivicdata:master.

@paultag
Copy link
Contributor

paultag commented Jun 5, 2015

Oh noes! I didn't mean move settings.py into core! Just the ES object; shucks, sorry!

@rshorey
Copy link
Contributor

rshorey commented Jun 5, 2015

merge issue seems to be in dump.py:

<<<<<<< HEAD
from pupa.core import settings

from .base import BaseCommand, CommandError

from ... import settings
from .base import BaseCommand

master

@rshorey
Copy link
Contributor

rshorey commented Jun 5, 2015

damn markup. just look at the raw version.

@mileswwatkins
Copy link
Contributor Author

Thanks for the merge bug, Carl 👺

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.2%) to 88.78% when pulling d64325a on mileswwatkins:miles/feature/fulltext_search into 59c883c on opencivicdata:master.

@mileswwatkins
Copy link
Contributor Author

Not yet, @paultag :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.2%) to 88.78% when pulling 7b48b94 on mileswwatkins:miles/feature/fulltext_search into 59c883c on opencivicdata:master.

@mileswwatkins
Copy link
Contributor Author

Okay, I believe this is ready to merge into production. The main thing we need to do from here is add by-jurisdiction text cleaning.

@mileswwatkins
Copy link
Contributor Author

@rshorey, I don't think this interferes with anything else going on in Pupa. Could you give it a pair of eyes sometime next week? Would be much appreciated!

@mileswwatkins mileswwatkins mentioned this pull request Jun 29, 2015
Open
@mileswwatkins
Copy link
Contributor Author

Closing in favor of a Postgres solution, per the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mileswwatkins @coveralls @paultag @rshorey