Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

body member cannot occupy both a membership post and a leadership post #244

Closed
fgregg opened this issue Jan 30, 2017 · 1 comment · Fixed by #245
Closed

body member cannot occupy both a membership post and a leadership post #244

fgregg opened this issue Jan 30, 2017 · 1 comment · Fixed by #245

Comments

@fgregg
Copy link
Contributor

fgregg commented Jan 30, 2017

Relates to popolo-project/popolo-spec#125

I need to keep track of the posts that make a member part of a body and any leadership posts they have in the body (like "speaker"). This now seems impossible with pupa's duplicate checking.

pupa.exceptions.DuplicateItemError: attempt to import data that would conflict with data already in the import: 
{'role': '1st Vice Chair', 'post_id': None, 'on_behalf_of_id': None, 
  'start_date': '2014-07-01', 'person_id': 'ocd-person/c976773c-c13e-485c-bbd6-0a007970f029', 
  'label': '', 'end_date': '2015-06-30', 
  'organization_id': 'ocd-organization/42e23f04-de78-436a-bec5-ab240c1b977c', 'extras': {}} 
(already imported as Mark Ridley-Thomas in Board of Directors (Board Member))

Do we want to change how we do do duplicate checking? Attn @jamesturk @jpmckinney

@jpmckinney
Copy link
Member

Sounds good to me. I can't see a consequence of adding 'role' to the uniqueness test for memberships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants