Update us_state_courts.csv

[ballotpedia]

Add Washington Court of Appeals subdivisions

[jloutsenhizer]

Looks good overall, please run compile.py to update the country-us.csv

[ballotpedia]

Thanks for the comments @jloutsenhizer. Could we get some more guidance on the process for implementing these changes at some point? I am not totally clear on what sort of script you are asking us to run, or what kinds of approval is needed as we make these requests to the repo, so any summary of the steps involved would be helpful. Thanks! -Matt

[jloutsenhizer]

Sorry for delays in replying.

The script I'm referring to is: https://github.com/opencivicdata/ocd-division-ids/blob/master/scripts/compile.py

It takes the files within in country directory and updates the country-xx.csv file. All PRs should use that script to ensure those files are up to date. There are also automated tests which verify this has been run. Example

As for approvals, the typical process is that at least 2 approvals are required. Typically once someone has reviewed the PR and approved it, we'll pull in another reviewer that's eligible to approve and merge the PR. Let me know if there's more questions.

[jpmckinney]

Hmm, so we already have ocd-division/country:us/state:wa/court_of_appeals:1 for WA State Court of Appeals - 1st Division, etc.

I think the districts should hang off these existing parents, so ocd-division/country:us/state:wa/court_of_appeals:1/district:1, etc.

[jloutsenhizer]

@jpmckinney I'm not sure if the districts of the divisions should be nested. Identifiers nesting is generally only used in connection with the level of jurisdiction of the governmental body reponsible for determining those districts. This was based on past discussions in:

• Incorrect Country Code used for United Kingdom #184
• migrate country:uk ids to country:gb v2 #188

Let me know if you think that rule doesn't apply here

[jpmckinney]

If some software asks "How many court_of_appeals divisions are there in the State of Washington?", then after this PR, the answer would be 12. Right now, the answer is 3 (correct). I think the IDs need to be structured to answer this question correctly.

[jloutsenhizer]

That's a fair point, I suppose either the types would have to be different on the district OCD IDs or nesting would also accomplish this. I think nesting looks cleaner so I agree with your recommendation

[ballotpedia]

We've submitted a new pull request that addresses the requested changes #321