Fix accounting of the pending update counter

There are two issues:
- In peer_blast_upcall() pending_update must be increased for every
  prefix inserted.
- In prefix_adjout_flush_pending() the EoR marker needs special handling.
  The EoR marker is not accounted but must be freed here.

OK tb@

Author: cjeker

usr.sbin/bgpd/rde_peer.c

@@ -1,4 +1,4 @@
-/*	$OpenBSD: rde_peer.c,v 1.47 2025/02/20 19:47:31 claudio Exp $ */
+/*	$OpenBSD: rde_peer.c,v 1.48 2025/03/14 12:39:55 claudio Exp $ */
 
 /*
  * Copyright (c) 2019 Claudio Jeker <[email protected]>
@@ -523,14 +523,18 @@ peer_stale(struct rde_peer *peer, uint8_t aid, int flushall)
 static void
 peer_blast_upcall(struct prefix *p, void *ptr)
 {
+	struct rde_peer		*peer;
+
 	if (p->flags & PREFIX_FLAG_DEAD) {
 		/* ignore dead prefixes, they will go away soon */
 	} else if ((p->flags & PREFIX_FLAG_MASK) == 0) {
+		peer = prefix_peer(p);
 		/* put entries on the update queue if not already on a queue */
 		p->flags |= PREFIX_FLAG_UPDATE;
-		if (RB_INSERT(prefix_tree, &prefix_peer(p)->updates[p->pt->aid],
+		if (RB_INSERT(prefix_tree, &peer->updates[p->pt->aid],
 		    p) != NULL)
 			fatalx("%s: RB tree invariant violated", __func__);
+		peer->stats.pending_update++;
 	}
 }
 

usr.sbin/bgpd/rde_rib.c

@@ -1,4 +1,4 @@
-/*	$OpenBSD: rde_rib.c,v 1.267 2025/01/14 12:24:23 claudio Exp $ */
+/*	$OpenBSD: rde_rib.c,v 1.268 2025/03/14 12:39:55 claudio Exp $ */
 
 /*
  * Copyright (c) 2003, 2004 Claudio Jeker <[email protected]>
@@ -1430,7 +1430,11 @@ prefix_adjout_flush_pending(struct rde_peer *peer)
 		RB_FOREACH_SAFE(p, prefix_tree, &peer->updates[aid], np) {
 			p->flags &= ~PREFIX_FLAG_UPDATE;
 			RB_REMOVE(prefix_tree, &peer->updates[aid], p);
-			peer->stats.pending_update--;
+			if (p->flags & PREFIX_FLAG_EOR) {
+				prefix_adjout_destroy(p);
+			} else {
+				peer->stats.pending_update--;
+			}
 		}
 	}
 }