Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use Inventory Item "PrettyName" #204

Open
gtmills opened this issue May 5, 2021 · 4 comments
Open

Should use Inventory Item "PrettyName" #204

gtmills opened this issue May 5, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@gtmills
Copy link
Member

gtmills commented May 5, 2021

We should map "PrettyName" to Redfish Name.

https://github.com/openbmc/phosphor-dbus-interfaces/blob/495981805244269650bee13d1ee8f13543b2bc5a/xyz/openbmc_project/Inventory/Item.interface.yaml#L5

Drives, Processors, etc, etc. all need to be moved.
@gtmills gtmills added the enhancement New feature or request label May 5, 2021
@gtmills gtmills mentioned this issue May 7, 2021
Closed
@gtmills
Copy link
Member Author

gtmills commented May 10, 2021

Name is a required property so probably want to do something here where we fall back to the last segment of the URI if there isn't a PrettyName interface

@gtmills
Copy link
Member Author

gtmills commented Jun 25, 2021

See https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/43967

@edtanous
Copy link
Contributor

Anyone still working on this? Aformentioned review was abandoned.

@gtmills
Copy link
Member Author

gtmills commented Dec 9, 2024

We use this downstream. Let me see if I can get someone to pick back up in the coming months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edtanous @gtmills