config Support json containing tabs

json is not technically a subset of yaml because yaml don't support tabs while json does

Signed-off-by: Pierre Tardy <[email protected]>

Author: tardyp

openapi_python_client/config.py

@@ -1,3 +1,5 @@
+import json
+import mimetypes
 from pathlib import Path
 from typing import Dict, List, Optional
 
@@ -35,6 +37,10 @@ class Config(BaseModel):
     @staticmethod
     def load_from_path(path: Path) -> "Config":
         """Creates a Config from provided JSON or YAML file and sets a bunch of globals from it"""
-        config_data = yaml.safe_load(path.read_text())
+        mime = mimetypes.guess_type(path.as_uri(), strict=True)[0]
+        if mime == "application/json":
+            config_data = json.loads(path.read_text())
+        else:
+            config_data = yaml.safe_load(path.read_text())
         config = Config(**config_data)
         return config

tests/test_config.py

@@ -1,5 +1,9 @@
+import json
 import pathlib
 
+import pytest
+import yaml
+
 from openapi_python_client.config import Config
 
 
@@ -28,3 +32,28 @@ def test_load_from_path(mocker):
     assert config.project_name_override == "project-name"
     assert config.package_name_override == "package_name"
     assert config.package_version_override == "package_version"
+
+
+DATA = {"class_overrides": {"Class1": {"class_name": "ExampleClass", "module_name": "example_module"}}}
+
+
+def json_with_tabs(d):
+    return json.dumps(d, indent=4).replace("    ", "\t")
+
+
+@pytest.mark.parametrize(
+    "filename,dump",
+    [
+        ("example.yml", yaml.dump),
+        ("example.json", json.dumps),
+        ("example.yaml", yaml.dump),
+        ("example.json", json_with_tabs),
+    ],
+)
+def test_load_filenames(tmp_path, filename, dump):
+    yml_file = tmp_path.joinpath(filename)
+    with open(yml_file, "w") as f:
+        f.write(dump(DATA))
+
+    config = Config.load_from_path(yml_file)
+    assert config.class_overrides == DATA["class_overrides"]