Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Gym environment requirements by algorithm #143

Open
nealmcb opened this issue Apr 17, 2019 · 1 comment
Open

Document Gym environment requirements by algorithm #143

nealmcb opened this issue Apr 17, 2019 · 1 comment

Comments

@nealmcb
Copy link

nealmcb commented Apr 17, 2019

Some or all of the algorithms seem to have requirements on which gym environments they work with.

There is a rich variety of environments, with some aging information on some of them from a few years ago as documented in openai/gym#106 and at Table of environments · openai/gym Wiki

As noted e.g. in #132 "Valid Gym environments to use",

FetchReach environment has Dict observation space (because it packages not only arm position, but also the target location into the observation), and spinning up does not implement support for Dict observation spaces yet.

In another random environment I found elsewhere on GitHub (Banana-v0), I got this error from ppo:

  File "/srv/s/aima/spinningup/spinningup/spinup/algos/ppo/ppo.py", line 256, in ppo
    a, v_t, logp_t = sess.run(get_action_ops, feed_dict={x_ph: o.reshape(1,-1)})         
AttributeError: 'list' object has no attribute 'reshape'

because it returns a list, not an array of observations.

So it would help to have documentation on what the algorithms require now, and lists of what outstanding capabilities could be easily integrated (as described in that issue about FetchReach) as low-hanging fruit here for contributions.

@nealmcb
Copy link
Author

nealmcb commented Apr 18, 2019

Another useful example, and commentary on ppo requiring Box (real-valued) observation vectors can be seen in #12 Test script failed in FetchPush-v1 and HandManipulatePen-v0.

See also #122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant