Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): remove unnecessary model parameter and require azure deployment #2123

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(azure): remove unnecessary model parameter and require azure deployment #2123

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b460ef1
fix(azure): require azure deployment and update query parameters
Programmer-RD-AI Feb 15, 2025
0284201
refactor(azure): remove model parameter from _configure_realtime and …
Programmer-RD-AI Feb 15, 2025
f7d5abc
fix(azure): add support for Azure AD token authentication in auth hea…
Programmer-RD-AI Feb 15, 2025
4def580
fix(azure): enforce azure deployment requirement in _configure_realti…
Programmer-RD-AI Feb 18, 2025
117720c
fix(azure): streamline base_url assignment and ensure deployment is i…
Programmer-RD-AI Feb 18, 2025
aa56dd8
fix(azure): update _configure_realtime method to accept model paramet…
Programmer-RD-AI Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/openai/lib/azure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,12 +307,14 @@ def _prepare_options(self, options: FinalRequestOptions) -> FinalRequestOptions:

return options

def _configure_realtime(self, model: str, extra_query: Query) -> tuple[Query, dict[str, str]]:
def _configure_realtime(self, extra_query: Query) -> tuple[Query, dict[str, str]]:
if not self._azure_deployment:
raise ValueError("Azure deployment is required for this API")
auth_headers = {}
query = {
**extra_query,
"api-version": self._api_version,
"deployment": model,
"deployment": self._azure_deployment,
}
if self.api_key != "<missing API key>":
auth_headers = {"api-key": self.api_key}
Expand Down Expand Up @@ -571,12 +573,14 @@ async def _prepare_options(self, options: FinalRequestOptions) -> FinalRequestOp

return options

async def _configure_realtime(self, model: str, extra_query: Query) -> tuple[Query, dict[str, str]]:
async def _configure_realtime(self, extra_query: Query) -> tuple[Query, dict[str, str]]:
if not self._azure_deployment:
raise ValueError("Azure deployment is required for this API")
auth_headers = {}
query = {
**extra_query,
"api-version": self._api_version,
"deployment": model,
"deployment": self._azure_deployment,
}
if self.api_key != "<missing API key>":
auth_headers = {"api-key": self.api_key}
Expand Down
4 changes: 2 additions & 2 deletions src/openai/resources/beta/realtime/realtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ async def __aenter__(self) -> AsyncRealtimeConnection:
extra_query = self.__extra_query
auth_headers = self.__client.auth_headers
if is_async_azure_client(self.__client):
extra_query, auth_headers = await self.__client._configure_realtime(self.__model, extra_query)
extra_query, auth_headers = await self.__client._configure_realtime(extra_query)

url = self._prepare_url().copy_with(
params={
Expand Down Expand Up @@ -506,7 +506,7 @@ def __enter__(self) -> RealtimeConnection:
extra_query = self.__extra_query
auth_headers = self.__client.auth_headers
if is_azure_client(self.__client):
extra_query, auth_headers = self.__client._configure_realtime(self.__model, extra_query)
extra_query, auth_headers = self.__client._configure_realtime(extra_query)

url = self._prepare_url().copy_with(
params={
Expand Down