Skip to content

Assistant - Fix null-reference exception when accessing RunStepDetailsUpdate.FunctionName #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Assistant - Fix null-reference exception when accessing RunStepDetailsUpdate.FunctionName #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Custom/Assistants/Streaming/RunStepDetailsUpdate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public IReadOnlyList<RunStepUpdateCodeInterpreterOutput> CodeInterpreterOutputs
=> _asCodeCall?.CodeInterpreter?.Outputs;

/// <inheritdoc cref="InternalRunStepDeltaStepDetailsToolCallsFunctionObjectFunction.Name"/>
public string FunctionName => _asFunctionCall.Function?.Name;
public string FunctionName => _asFunctionCall?.Function?.Name;

/// <inheritdoc cref="InternalRunStepDeltaStepDetailsToolCallsFunctionObjectFunction.Arguments"/>
public string FunctionArguments => _asFunctionCall?.Function?.Arguments;
Expand Down
6 changes: 6 additions & 0 deletions tests/Assistants/AssistantsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,12 @@
{
message += $"{contentUpdate.Text}";
}
else if (update is RunStepDetailsUpdate detailUpdate)
{
string? functionName = "none"; // expect null assignment on next line

Check warning on line 1020 in tests/Assistants/AssistantsTests.cs

View workflow job for this annotation

GitHub Actions / Build 

The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Assert.DoesNotThrow(() => functionName = detailUpdate.FunctionName);
Assert.Null(functionName);
}
}
}
else
Expand Down
Loading