Skip to content

Added mcp 'instructions' attribute to the server #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2025
Merged

Added mcp 'instructions' attribute to the server #706

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f80f0e
Added mcp 'instructions' attribute to the server
DanieleMorotti May 16, 2025
cb5c39e
fixed error if server result is None on initialization
DanieleMorotti May 16, 2025
eee02f3
Solved lint error for line too long
DanieleMorotti May 16, 2025
322d1bd
Saved "InitializeResult" object instead of "instructions" only
DanieleMorotti May 18, 2025
6cc87bb
added None as allowed default type for type checking
DanieleMorotti May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/agents/mcp/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ def __init__(self, cache_tools_list: bool, client_session_timeout_seconds: float
self.exit_stack: AsyncExitStack = AsyncExitStack()
self._cleanup_lock: asyncio.Lock = asyncio.Lock()
self.cache_tools_list = cache_tools_list
self.instructions: str | None = None

self.client_session_timeout_seconds = client_session_timeout_seconds

Expand Down Expand Up @@ -122,7 +123,8 @@ async def connect(self):
else None,
)
)
await session.initialize()
server_result = await session.initialize()
self.instructions = getattr(server_result, "instructions", None)
Copy link
Collaborator

@rm-openai rm-openai May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use getattr? I see initialize() returns types.InitializeResult, which has instructions: str | None = None

In fact, we should probably just set self.server_initialize_result. That way devs can read other info too, e.g. protocol version or capabilities

Copy link
Contributor Author

@DanieleMorotti DanieleMorotti May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you prefer, the issue was about instructions so I read that value, but now I set the variable as you suggested.

self.session = session
except Exception as e:
logger.error(f"Error initializing MCP server: {e}")
Expand Down