Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix box2d tests #98

Closed
wants to merge 4 commits into from
Closed

Fix box2d tests #98

wants to merge 4 commits into from

Conversation

gdb
Copy link
Collaborator

@gdb gdb commented May 16, 2016

No description provided.

@jietang
Copy link
Contributor

jietang commented Jun 29, 2016

whoa this is old. @jonasschneider, do you remember the context?

@jonasschneider
Copy link
Contributor

The Box2D python bindings distribution is very broken. See #100.

Dumping what I remember: I think the source is https://github.com/pybox2d/pybox2d, published to https://pypi.python.org/pypi/Box2D. However, that is an old version that has the SWIG version requirement/bug. I forked the source to https://github.com/jonasschneider/box2d-py and pushed https://pypi.python.org/pypi/box2d-py to have the latest version available, which is what gym now depends on.

I'm not sure what changes have been merged in the meanwhile and if this patch still applies. If these tests are currently passing, I'd recommend to not merge. However, #100 looks like people are still having problems there, so it might be worth investigating all the of the box2d strangeness more.

@gdb
Copy link
Collaborator Author

gdb commented Jun 29, 2016

I never actually got the Travis tests for box2d working. (I thought this PR would do it, but I was wrong, and decided to wait for @jonasschneider to be back from vacation!)

@jonasschneider
Copy link
Contributor

A-ha! Yep, then I'll take this up again.

@gdb
Copy link
Collaborator Author

gdb commented Aug 22, 2016

@jonasschneider should we actually be able to fix these tests now?

@pzhokhov
Copy link
Collaborator

pzhokhov commented Mar 2, 2019

travis tests for box2d are working now, closing this

@pzhokhov pzhokhov closed this Mar 2, 2019
@jkterry1 jkterry1 deleted the box2dtests branch August 5, 2021 06:10
@jkterry1 jkterry1 restored the box2dtests branch August 5, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants