Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #100 with new Box2D-kengz dependency #558

Merged
merged 1 commit into from
Apr 22, 2017
Merged

Conversation

kengz
Copy link
Contributor

@kengz kengz commented Apr 11, 2017

This fixes #100 Box2d won't find some RAND_LIMIT_swigconstant

The issue has proven a hurdle for users who wants to get started on the gym, or for developers who builds projects with gym as the dependency since a clean install will have the broken 2d environments.

Steps:

  • clone the Box2D repo, release a fixed version to PyPi as Box2D-kengz at version 2.3.3 (since the author seems inactive). The fork is here.
  • update gym's dependency in setup.py to point to this package
  • test the installation with LunarLander-v2 environment on direct install of gym from my fork. Issue resolved.

@andrewschreiber
Copy link
Contributor

andrewschreiber commented Apr 19, 2017

It's a good move to switch to Kengz's fork as the original PyBox2D maintainer @kne has not merged a PR for several months and is seemingly unreachable. A PR to fix the issue on PyBox2D has been open since February 14th.

I can say that Kengz's pip install -e git+https://github.com/kengz/gym.git#egg=gym[all] made my LunarLander-v2 environment work perfectly.

@danijar
Copy link

danijar commented Apr 22, 2017

@gdb Is there anything that keeps this from getting merged?

@gdb
Copy link
Collaborator

gdb commented Apr 22, 2017

This is great. Thank you @kengz!

@gdb gdb merged commit 95ec4c1 into openai:master Apr 22, 2017
gdb added a commit that referenced this pull request Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box2d won't find some RAND_LIMIT_swigconstant
4 participants