-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build - only install mujoco for python 3.6, 3.7, #2133
Conversation
…ing because of that
If I understand correctly this just disables mujuco tests on python 3.8 and 3.9? that seems like a less than ideal solution. |
@justinkterry correct. FWIW to my knowledge mujoco 1.50 never worked well with 3.8 and 3.9 - so I am down to re-enable them once we make the tests work (and not segfault) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'd double check the operator precedence on that bash command though, if it matters. Maybe also add a comment about why this is here.
@christopherhesse thanks! Basically, I checked that 3.6 and 3.7 builds install mujoco, and 3.8 and 3.9 do not... Do you think there are any other gotchas? |
@pzhokhov My knowledge of mujuco is limited, but shouldnt the mujuco-py version just be bumped then? |
no, I am pretty sure we tried it in the past (as in, mujoco 2.0) and it had more issues of its own. This is not to say it's not possible, but at the time we decided the investment in fixing all the breaks that mujoco 2.0 introduced was not worth it. |
see #1731 for context |
@justinkterry I scheduled a new pypi release, 0.18.0 - will be done at the end of this build: https://travis-ci.org/github/openai/gym/builds/750492489 |
* reverting to older version of 3.6 python to test if the build is failing because of that * revert 3.7 to 3.7.3 for the build * revert python 3.8 version to 3.8.1 * do not install mujoco on 3.8 and 3.9 * enable mujoco for 3.7 * . * . * . * use regex to navigate python version dependent package installation * .
No description provided.