Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box2D dependency fails on Linux #1096

Closed
christopherhesse opened this issue Jul 11, 2018 · 7 comments
Closed

Box2D dependency fails on Linux #1096

christopherhesse opened this issue Jul 11, 2018 · 7 comments
Assignees

Comments

@christopherhesse
Copy link
Contributor

christopherhesse commented Jul 11, 2018

The Box2D library used by setup.py doesn't seem to work, and also the tests do not seem to catch this.

Steps to reproduce:

apt-get update
apt-get install swig
pip install gym[box2d]
python -c "import Box2D"

  File "<string>", line 1, in <module>
  File "/opt/conda/lib/python3.6/site-packages/Box2D/__init__.py", line 20, in <module>
    from .Box2D import *
  File "/opt/conda/lib/python3.6/site-packages/Box2D/Box2D.py", line 434, in <module>
    RAND_LIMIT = _Box2D.RAND_LIMIT
AttributeError: module 'Box2D._Box2D' has no attribute 'RAND_LIMIT'

@pzhokhov has suggested that box2d-py is in fact the correct dependency to put in setup.py and not box2d-kengz but that may require testing on mac and linux.

@DuaneNielsen
Copy link

I could only get it working on mac with box2d-kengz box2d didn't work for me...

@christopherhesse
Copy link
Contributor Author

@pzhokhov I tried box2d-py on my mac and it failed, it seems like box2d-kengz is required on mac while box2d-py is required on linux. Is there some way to make this work correctly on both platforms?

@christopherhesse
Copy link
Contributor Author

christopherhesse commented Jul 19, 2018

This also implies we have no mac tests for these environments, is that the case?

@christopherhesse
Copy link
Contributor Author

Since there is no valid configuration of box2d packages, could we get a note in the readme or something as a workaround until we have a box2d package that works? @pzhokhov

@BStudent
Copy link

BStudent commented Aug 6, 2018

box2d doesn't seem to work currently for Pop!_OS (System76' GPU-friendly unbuntu derivative), however box2d-kengz does.

@pzhokhov
Copy link
Collaborator

pzhokhov commented Aug 6, 2018

added a note to README:
#1120

@christopherhesse
Copy link
Contributor Author

This was fixed by #1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants