Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_action_space_info not complete #15

Open
JoostvDoorn opened this issue Aug 29, 2016 · 6 comments
Open

get_action_space_info not complete #15

JoostvDoorn opened this issue Aug 29, 2016 · 6 comments

Comments

@JoostvDoorn
Copy link

The function get_action_space_info does not return the action space when the action space contains a Tuple. It will just return {'name': 'Tuple'}. Tested on Copy-v0.

@korymath
Copy link
Contributor

Could you provide a minimal test case code sample to help with debugging and testing?

@JoostvDoorn
Copy link
Author

Sure here you go:

import logging
import os, sys
import numpy as np

from gym_http_client import Client

remote_base = 'http://127.0.0.1:5000'
client = Client(remote_base)

env_id = 'Copy-v0'
instance_id = client.env_create(env_id)
print(client.env_action_space_info(instance_id))

@JoostvDoorn
Copy link
Author

To elaborate on this _get_space_properties does not seem to be fully implemented to support all properties, see: https://github.com/openai/gym-http-api/blob/master/gym_http_server.py#L92

@kashif
Copy link

kashif commented Sep 20, 2016

indeed... if we can specify how to serialize a Tuple to json then i can add that case in the server code...

@korymath
Copy link
Contributor

Potentially addressed with recent commit: 1b42f25

Does this get at exactly what you need? If so, then it is a matter of implementing something similar in the info call as what is in the sample call.

@markroxor
Copy link

The problem is with the environment - Copy-v0. It has three actions with a couple of sub actions within them, unlike CartPole-v0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants