[Bug]: improper handling of approvals

[pawelczak10]

Description

When making a request to mcp based on open ai documentation, I get the following error:

"/vendor/openai-php/client/src/Responses/Responses/Tool/RemoteMcpTool.php"

"OpenAI\Responses\Responses\Tool\RemoteMcpTool::{closure:OpenAI\Responses\Responses\Tool\RemoteMcpTool::from():49}(): Argument #1 ($approvalAttributes) must be of type array, null given"

Steps To Reproduce

Is the approval service available in the latest version?

OpenAI PHP Client Version

0.16

PHP Version

8.3

Notes

No response

[iBotPeaches]

Thanks for report. So I assume I can replicate this by changing my example to not require approval? https://github.com/iBotPeaches/openai-php-laravel-test/blob/master/app/Console/Commands/ResponsesMcpTest.php

[pawelczak10]

Not quite. If require_approval is set directly to never, everything works correctly. The problem arises when we want to configure the tools so that only some of them do not require approval.

[iBotPeaches]

Yep so I need to introduce a new sample that requires approval to replicate this.

[pawelczak10]

Is a list of tools that require approval required? If I specify a list of tools as “never,” will the remaining tools be selected as “always” by default?

According to the documentation, the “always” parameter is not required. However, if I only use only the ‘never’ parameter and specify tools that do not require approval, the above error appears. On the other hand, after adding extra the “always” parameter, everything works correctly.

[iBotPeaches]

{
    "tools": [
        {
            "type": "mcp",
            "allowed_tools": null,
            "headers": null,
            "require_approval": {
                "always": null,
                "never": {
                    "read_only": null,
                    "tool_names": [
                        "ask_question",
                        "read_wiki_structure"
                    ]
                }
            },
            "server_description": null,
            "server_label": "deepwiki",
            "server_url": "https://mcp.deepwiki.com/<redacted>"
        }
    ]
}

Upgraded my sample and confirm the issue. Sample payload above.

[iBotPeaches]

I put up a fix where I clear out the entity if null (in the case of my sample above always). I'm debating whether to keep it as null or strip it out.

#669

[pawelczak10]

Perfect, thanks for fix!
When can I expect the release of the new version v0.17?

[iBotPeaches]

Perfect, thanks for fix! When can I expect the release of the new version v0.17?

Probably after Conversation API is done or end of Sept at worst.

[ruslan-polutsygan]

@iBotPeaches When do you expect conversation API to be done/released?
Thanks

[iBotPeaches]

@iBotPeaches When do you expect conversation API to be done/released? Thanks

Probably 2-5 days

[ruslan-polutsygan]

Probably 2-5 days

Thank you. Looking forward for the release. Need to move from Assistance API to Conversation API 😄