Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add rabbitmq msg for announcer #1845

Closed

Conversation

dcermak
Copy link
Contributor

@dcermak dcermak commented Jan 22, 2019

This fixes #1834.

The whole code is untested, since I wasn't able to find any test code for announcer.py. I would be more than happy to add some tests to this, as I have absolutely no idea whether this works.

@coveralls
Copy link

coveralls commented Jan 22, 2019

Pull Request Test Coverage Report for Build 4553

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.183%

Totals Coverage Status
Change from base Build 4550: 0.0%
Covered Lines: 4184
Relevant Lines: 14846

💛 - Coveralls

@dcermak dcermak force-pushed the add_rabbitmq_msg_for_announcer branch from abbcf48 to c71c685 Compare January 22, 2019 15:48
@dcermak dcermak force-pushed the add_rabbitmq_msg_for_announcer branch from c71c685 to 085dc22 Compare January 22, 2019 16:14
@jberry-suse
Copy link
Contributor

This would seem to be backwards. OBS should be emitting an event that the announcer listens for to send out an e-mail.

@dcermak
Copy link
Contributor Author

dcermak commented Jan 23, 2019

In this case OBS is not sufficient, the factory-package-news script is invoked by openQA after a new changelog is created (I think). But I tend to agree with you, this process seems the wrong way around.

@DimStar77 you probably know more about this and what the right procedure is.

@coolo
Copy link
Member

coolo commented Jan 23, 2019

OBS sends out an event if openSUSE:Factory:ToTest/images is published - containing this ISO. I wonder what's your use case.

@dcermak
Copy link
Contributor Author

dcermak commented Jan 24, 2019

I would like to run a build using the fresh Tumbleweed image, once it got released. Originally I wanted to listen for the rabbitmq event that ttm sends around, but Dominique told me that they are probably firing too soon and that OBS still has to do the release afterwards.

@DimStar77
Copy link
Contributor

OBS sends out an event if openSUSE:Factory:ToTest/images is published - containing this ISO. I wonder what's your use case.

the problem at this time is that download.o.o will only be updated in like 2 - 3 hours, as we hold off the switch for mirrors to catch up. Hence the idea of the announcer also creating an event - as it actually monitors when the publishing is actually really done and ready for users to consuime download.o.o again

Preferably this event would come from another place, like the "publisher holding off"-script for example, at the time when it does the switch - but anybody daring to touch that code will curse for the rest of his life

IFF we would add rabitmq to the publisher scripts, then of course the announcer would/could/should listen as well

@jberry-suse
Copy link
Contributor

/me remembers a proposal on this topic. oh well.

@coolo
Copy link
Member

coolo commented Jan 24, 2019

Preferably this event would come from another place, like the "publisher holding off"-script for example, at the time when it does the switch - but anybody daring to touch that code will curse for the rest of his life

now that explains @lnussel's behavior! :)

@dcermak
Copy link
Contributor Author

dcermak commented Jan 25, 2019

Since I am quite inexperienced with the openSUSE infrastructure, what do you all think that should be done about this? If this is not the way forward, I'd rather close this and discuss a better solution in #1834.

@dcermak dcermak closed this Feb 5, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] factory-package-news could send a rabbitmq message
5 participants